linux-kernel - Re: [PATCH] uprobes/core: handle breakpoint and signal step exception.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Mar 2012 06:42:42 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Oleg Nesterov <oleg@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Anton Arapov <anton@...hat.com>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Jim Keniston <jkenisto@...ux.vnet.ibm.com>,
	Jiri Olsa <jolsa@...hat.com>, Josh Stone <jistone@...hat.com>
Subject: Re: [PATCH] uprobes/core: handle breakpoint and signal step
 exception.


* Ingo Molnar <mingo@...e.hu> wrote:

> I.e. you could drop this patch altogether:
> 
>   x86/trivial: Fix 'old_rsp' undefined build failure when including asm/compat.h
> 
> And rework the is_ia32_compat_task() patch to use another 
> header and to use the is_32bit_task() name. Also, you should 
> double check whether the x32 execution model needs special 
> consideration as well:
> 
>  #define TIF_IA32		17	/* IA32 compatibility process */
>  #define TIF_X32		30	/* 32-bit native x86-64 binary */
> 
> otherwise uprobe will not work with x32 tasks properly.

Given that x32 tasks are using native 64-bit syscalls, what you 
need is the is_ia32_task() check. We have that in -tip already, 
in compat.h. If uprobes uses that definition then uprobes will 
be able to probe x32 tasks as well.

To make it available to uprobes please move is_ia32_task() to 
processor.h and make it return 1 on i386 kernels. This should be 
a very simple patch - and that's all that is needed.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/