linux-kernel - Re: [PATCH 2/5] Correctly clean up pci root buses in function pci_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <4F5EF5F2.2000507@huawei.com>
Date:	Tue, 13 Mar 2012 15:23:30 +0800
From:	Jiang Liu <jiang.liu@...wei.com>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Jiang Liu <liuj97@...il.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Ashok Raj <ashok.raj@...el.com>,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	Youquan Song <youquan.song@...el.com>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	chenkeping@...wei.com
Subject: Re: [PATCH 2/5] Correctly clean up pci root buses in function
 pci_remove_bus()

Hi Yinghai,
	Good points! It's safe with current implementation because
all root bus hotplug operations are under protection of 
pci_remove_rescan_mutex.

On 2012-3-13 14:24, Yinghai Lu wrote:
> On Sun, Mar 11, 2012 at 10:48 AM, Jiang Liu<liuj97@...il.com>  wrote:
>> The function pci_create_root_bus() allocates the pci bus structure,
>> registers the bus device and creates the legacy files for a pci root
>> bus, but returns without setting the is_added flag. The is_added flag
>> for a pci root bus will be set by function pci_scan_child_bus().
>
>> If a pci root bus is destroyed before calling pci_scan_child_bus(),
>> the is_added flag will not be set.
>
> how that can be met?
>
> Do we have pci_remove_rescan_mutex around them?
>
> Yinghai
>
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/