linux-kernel - Re: [PATCH v11 3/3] iommu/exynos: Add iommu driver for Exynos Platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120313100024.GG18973@amd.com>
Date:	Tue, 13 Mar 2012 11:00:24 +0100
From:	Joerg Roedel <joerg.roedel@....com>
To:	KyongHo Cho <pullip.cho@...sung.com>
CC:	Kukjin Kim <kgene.kim@...sung.com>,
	Subash Patel <subash.ramaswamy@...aro.org>,
	<linux-kernel@...r.kernel.org>,
	Younglak Kim <younglak1004.kim@...sung.com>,
	<iommu@...ts.linux-foundation.org>,
	<linux-samsung-soc@...r.kernel.org>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Sanghyun Lee <sanghyun75.lee@...sung.com>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v11 3/3] iommu/exynos: Add iommu driver for Exynos
 Platforms

On Tue, Mar 13, 2012 at 05:50:16PM +0900, KyongHo Cho wrote:
> >> +struct sysmmu_drvdata {
> >> +     struct device *sysmmu;
> >> +     char *dbgname;
> >> +     int nsfrs;
> >> +     void __iomem **sfrbases;
> >> +     struct clk *clk[2];
> >> +     int activations;
> >> +     rwlock_t lock;
> >> +     struct iommu_domain *domain;
> >> +     sysmmu_fault_handler_t fault_handler;
> >> +     unsigned long pgtable;
> >> +     struct iommu_client client;
> >> +};
> >
> > Is there any reason why 'struct iommu_client' is a seperate data
> > structure? Otherwise it can be merged with 'truct sysmmu_drvdata'.

Of course this doesn't need to be changed immediatly. I just asked if
there was a specific reason for this seperation.

> The problems will be soon fixed and I will post next patch tomorrow.

Fine. Please also get the Acked-bys from the Exynos maintainer on
patches 1 and 2 at least. I'll merge it then.


	Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/