linux-kernel - Re: [PATCH 05/25] vfs: add filesystem flags for atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pqcg92dn.fsf@tucsk.pomaz.szeredi.hu>
Date:	Tue, 13 Mar 2012 12:17:08 +0100
From:	Miklos Szeredi <miklos@...redi.hu>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	viro@...IV.linux.org.uk, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, Trond.Myklebust@...app.com,
	sfrench@...ba.org, sage@...dream.net, ericvh@...il.com
Subject: Re: [PATCH 05/25] vfs: add filesystem flags for atomic_open

Christoph Hellwig <hch@...radead.org> writes:

> On Wed, Mar 07, 2012 at 10:22:22PM +0100, Miklos Szeredi wrote:
>> From: Miklos Szeredi <mszeredi@...e.cz>
>> 
>> Allow filesystem to select which cases it wants to perform atomic_open.
>
> Given that atomic_open is allowed to return a NULL filp and fall back to
> the traditional open I don't think this is needed - it can be much
> cleaner handled by the fs just returning NULL for that case.

Hmm, yeah.  The reason I did this was to prevent doing permission/
security checks twice before create.

But in fact that could be optimized away with careful code flow.  I'll
look into dropping this.

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/