linux-kernel - Re: [PATCH 13/25] cifs: implement i_op->atomic_open() and i_op->atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878vj48vsr.fsf@tucsk.pomaz.szeredi.hu>
Date:	Tue, 13 Mar 2012 14:39:16 +0100
From:	Miklos Szeredi <miklos@...redi.hu>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	viro@...IV.linux.org.uk, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, Trond.Myklebust@...app.com,
	sfrench@...ba.org, sage@...dream.net, ericvh@...il.com
Subject: Re: [PATCH 13/25] cifs: implement i_op->atomic_open() and i_op->atomic_create()

Christoph Hellwig <hch@...radead.org> writes:

> On Wed, Mar 07, 2012 at 10:22:30PM +0100, Miklos Szeredi wrote:
>> From: Miklos Szeredi <mszeredi@...e.cz>
>> 
>> Replace CIFS's ->create operation with ->atomic_open and ->atomic_create.  Also
>> move the relevant code from ->lookup into the create function.
>> 
>> CIFS currently only does atomic open for O_CREAT, but it wants to do that as
>> early as possible, without first calling ->lookup, so it uses ->atomic_open,
>> just like NFS.
>
> Why does cifs need to set the created flag from inside ->atomic_open?
>
> It's different from everyone else in that respect.

Apparently CIFS is the only one that can tell whether the file was
created or not.  If the flag is set then notify_create() is called.
Users of NFS doesn't seem to care, it's of dubious value anyway, but why
not use the info when available?

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/