| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1331656495.11405.4.camel@joe2Laptop> Date: Tue, 13 Mar 2012 09:34:55 -0700 From: Joe Perches <joe@...ches.com> To: dedekind1@...il.com Cc: David Woodhouse <dwmw2@...radead.org>, linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/4] jffs2: Convert most D1/D2 macros to jffs2_dbg On Tue, 2012-03-13 at 14:39 +0200, Artem Bityutskiy wrote: > On Mon, 2012-03-12 at 10:11 -0700, Joe Perches wrote: > > On Mon, 2012-03-12 at 18:35 +0200, Artem Bityutskiy wrote: > > > On Mon, 2012-03-12 at 08:33 -0700, Joe Perches wrote: > > > > I tentatively converted them to a bitmap > > > > and a single jffs2_dbg(mask, fmt, ...) > > > > but perhaps all of these could be deleted > > > > too. > > > I think it is better to convert them to jffs2_debug(). And I guess after > > > the change the "mask" parameter will go away? > > Mask would remain and perhaps become a module > > variable instead of a compile #define. > > What is jffs2_debug? > Sorry, I meant to suggest to just turn them all to jffs2_dbg() which you > introduced, without any bitmasks. These functions are conditionally compiled today. Introducing a bitmask allows the same conditional compilation optimization. David? as nominal maintainer, do you have an opinion? btw: Artem, you are not listed in the MAINTAINERS entry for jffs2. Should you be? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists