linux-kernel - Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Mar 2012 11:28:07 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Zach Sadecki <zsadecki@...atchdogs.com>,
	Rob Herring <robherring2@...il.com>
Cc:	Dong Aisheng <b29396@...escale.com>, vinod.koul@...ux.intel.com,
	devicetree-discuss@...ts.ozlabs.org, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org, rob.herring@...xeda.com,
	rdunlap@...otime.net, shawn.guo@...escale.com,
	kernel@...gutronix.de, cjb@...top.org, s.hauer@...gutronix.de,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

On Tue, 13 Mar 2012 09:59:39 -0500, Zach Sadecki <zsadecki@...atchdogs.com> wrote:
> On 03/13/2012 09:35 AM, Rob Herring wrote:
> > +	ahb@...80000 {
> > +		fec@...f0000 {
> > Use generic names: ethernet@...f0000
> Generic is good, but consistency is better, IMHO.  grepping existing dts 
> files in 3.2.9 finds 6 instances of "fec@" and 0 instances of "ethernet@"
> >> +			uart1: uart@...74000 {
> > Use generic names: uart1: serial@...
> Same comment here, but unfortunately there is already inconsistency in 
> existing files...  25 instances of "serial@" and 35 instances of "uart@"

No, Rob is correct.  The generic names recommended practice is well
established and documented.  Expand your grep search to include
arch/powerpc/bot/dts/*.

See section 2.2.2 of ePAPR[1]

[1]https://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.1.pdf

-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/