linux-kernel - Re: [PATCH 2/2] uprobes/core: Handle breakpoint and singlestep exception.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120313180536.GB21727@linux.vnet.ibm.com>
Date:	Tue, 13 Mar 2012 23:35:36 +0530
From:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Jim Keniston <jkenisto@...ux.vnet.ibm.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux-mm <linux-mm@...ck.org>, Oleg Nesterov <oleg@...hat.com>,
	Andi Kleen <andi@...stfloor.org>,
	Christoph Hellwig <hch@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 2/2] uprobes/core: Handle breakpoint and singlestep
 exception.

> 
> > diff --git a/kernel/fork.c b/kernel/fork.c
> > index 26a7a67..36508b9 100644
> > --- a/kernel/fork.c
> > +++ b/kernel/fork.c
> > @@ -67,6 +67,7 @@
> >  #include <linux/oom.h>
> >  #include <linux/khugepaged.h>
> >  #include <linux/signalfd.h>
> > +#include <linux/uprobes.h>
> >  
> >  #include <asm/pgtable.h>
> >  #include <asm/pgalloc.h>
> > @@ -731,6 +732,8 @@ void mm_release(struct task_struct *tsk, struct mm_struct *mm)
> >  		exit_pi_state_list(tsk);
> >  #endif
> >  
> > +	uprobe_free_utask(tsk);
> > +
> >  	/* Get rid of any cached register state */
> >  	deactivate_mm(tsk, mm);
> >  
> > @@ -1322,6 +1325,10 @@ static struct task_struct *copy_process(unsigned long clone_flags,
> >  	INIT_LIST_HEAD(&p->pi_state_list);
> >  	p->pi_state_cache = NULL;
> >  #endif
> > +#ifdef CONFIG_UPROBES
> > +	p->utask = NULL;
> > +	p->uprobe_srcu_id = -1;
> > +#endif
> >  	/*
> >  	 * sigaltstack should be cleared when sharing the same VM
> >  	 */
> 
> Hm, I suspect by looking at the first two hunks you can guess 
> how the third hunk should be done more cleanly?
> 

Resent just this patch after addressing this comment.

-- 
thanks and regards
Srikar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/