lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1331666651.25686.665.camel@gandalf.stny.rr.com>
Date:	Tue, 13 Mar 2012 15:24:11 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	rt-users <linux-rt-users@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Clark Williams <williams@...hat.com>,
	John Kacur <jkacur@...hat.com>
Subject: Re: [PATCH-RT] preempt.h: Fix implicit declaration of
 'preempt_check_resched_rt'

Thomas,

Can you apply this patch (with the fixed "tested-by") and push out a new
3.2-rt?

This bug is causing one of my "stable tests" to fail, and I wont push
out a new stable test until it passes. But I also wont add a fix that is
not in your tree. This means that 3.0-rt is being held back until this
gets applied.

Thanks,

-- Steve


On Thu, 2012-03-08 at 21:13 +0100, John Kacur wrote:
> When building a non-preempt kernel where CONFIG_PREEMPT_COUNT is not
> defined the following build break occurs.
> 
> /home/jkacur/linux-rt/block/blk-softirq.c: In function ‘trigger_softirq’:
> /home/jkacur/linux-rt/block/blk-softirq.c:54: error: implicit declaration of function ‘preempt_check_resched_rt’
> make[2]: *** [block/blk-softirq.o] Error 1
> make[1]: *** [block/blk-softirq.o] Error 2
> make: *** [sub-make] Error 2
> 
> This patch fixes the build error by adding a define to the
> !CONFIG_PREEMPT_COUNT section.
> 
> Signed-off-by: Clark Williams <williams@...hat.com>
> Signed-off-by: John Kacur <jkacur@...hat.com>
> ---
>  include/linux/preempt.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/preempt.h b/include/linux/preempt.h
> index fa40695..58d8982 100644
> --- a/include/linux/preempt.h
> +++ b/include/linux/preempt.h
> @@ -107,6 +107,7 @@ do { \
>  #define preempt_disable_notrace()		do { } while (0)
>  #define preempt_enable_no_resched_notrace()	do { } while (0)
>  #define preempt_enable_notrace()		do { } while (0)
> +#define preempt_check_resched_rt()	do { } while (0)
>  
>  #endif /* CONFIG_PREEMPT_COUNT */
>  


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ