linux-kernel - Re: [PATCH 1/1] of: add NULL parameter check for of_device_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120313.133419.2242081944811028058.davem@davemloft.net>
Date:	Tue, 13 Mar 2012 13:34:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	b29396@...escale.com
Cc:	devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	grant.likely@...retlab.ca, rob.herring@...xeda.com
Subject: Re: [PATCH 1/1] of: add NULL parameter check for
 of_device_is_available

From: Dong Aisheng <b29396@...escale.com>
Date: Tue, 13 Mar 2012 19:40:05 +0800

> From: Dong Aisheng <dong.aisheng@...aro.org>
> 
> This function will return 1 even the device node passed in
> is NULL which is a little error-prone.
> Change to return 0 if the device node passed in is NULL.
> 
> Signed-off-by: Dong Aisheng <dong.aisheng@...aro.org>

I think this is a hard error and therefore BUG_ON(!device) is
more appropriate.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/