linux-kernel - Re: [PATCH 2/2] page_alloc: Remove argument to find_zone_movable_pfns_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1203131345290.27008@chino.kir.corp.google.com>
Date:	Tue, 13 Mar 2012 13:47:47 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Kautuk Consul <consul.kautuk@...il.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mgorman@...e.de>, Tejun Heo <tj@...nel.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Minchan Kim <minchan.kim@...il.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] page_alloc: Remove argument to
 find_zone_movable_pfns_for_nodes

On Tue, 13 Mar 2012, Kautuk Consul wrote:

> The find_zone_movable_pfns_for_nodes() function does not utiilize
> the argument to it.
> 

It could, though, if we made it to do so.

> Removing this argument from the function prototype as well as its
> caller, i.e. free_area_init_nodes().
> 

Not sure if we'd ever want it or not for other purposes, but 
find_zone_movable_pfns_for_nodes() could easily be made to use the passed 
in array rather than zone_movable_pfn in file scope directly.  That seems 
to be why it took an argument in the first place.

> Signed-off-by: Kautuk Consul <consul.kautuk@...il.com>
> ---
>  mm/page_alloc.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 3171f4c..a368b9b 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -4509,7 +4509,7 @@ static unsigned long __init early_calculate_totalpages(void)
>   * memory. When they don't, some nodes will have more kernelcore than
>   * others
>   */
> -static void __init find_zone_movable_pfns_for_nodes(unsigned long *movable_pfn)
> +static void __init find_zone_movable_pfns_for_nodes(void)
>  {
>  	int i, nid;
>  	unsigned long usable_startpfn;
> @@ -4701,7 +4701,7 @@ void __init free_area_init_nodes(unsigned long *max_zone_pfn)
>  
>  	/* Find the PFNs that ZONE_MOVABLE begins at in each node */
>  	memset(zone_movable_pfn, 0, sizeof(zone_movable_pfn));
> -	find_zone_movable_pfns_for_nodes(zone_movable_pfn);
> +	find_zone_movable_pfns_for_nodes();
>  
>  	/* Print out the zone ranges */
>  	printk("Zone PFN ranges:\n");
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/