[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20120313231335.GQ3177@opensource.wolfsonmicro.com>
Date: Tue, 13 Mar 2012 23:13:36 +0000
From: Mark Brown <broonie@...nsource.wolfsonmicro.com>
To: Axel Lin <axel.lin@...il.com>
Cc: linux-kernel@...r.kernel.org,
Kyungmin Park <kyungmin.park@...sung.com>,
MyungJoo Ham <myungjoo.ham@...sung.com>,
Liam Girdwood <lrg@...com>
Subject: Re: [PATCH] regulator: Check SET[1|2|3] GPIO settings earlier
On Tue, Mar 13, 2012 at 10:58:20AM +0800, Axel Lin wrote:
> Unused GPIO is marked as -1, we need to check if one of the gpio is set to 0
> here because gpio_is_valid considers 0 as a valid gpio.
This will break existing boards, we need to manage the transfer more
gracefully and complain if we're using a GPIO 0. Though I'm not sure
it's worth bothering, I hope no modern gpiolib implementation will do
this.
Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)
Powered by blists - more mailing lists