linux-kernel - Re: [PATCH] Add I2C driver for Summit Microelectronics SMB347 Battery Charger.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 14 Mar 2012 03:46:56 +0400
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add I2C driver for Summit Microelectronics SMB347
 Battery Charger.

On Mon, Feb 06, 2012 at 04:01:27PM +0000, Mark Brown wrote:
> On Mon, Feb 06, 2012 at 03:59:01PM +0000, Alan Cox wrote:
> 
> > Driver support for the Summit I??C battery charger. This is used in some
> > Intel devices.
> 
> There's quite a lot of read/modify/write cycles and...
> 
> > +static int smb347_debugfs_show(struct seq_file *s, void *data)
> > +{
> > +	struct smb347_charger *smb = s->private;
> > +	int ret;
> > +	u8 reg;
> > +
> > +	seq_printf(s, "Control registers:\n");
> > +	seq_printf(s, "==================\n");
> 
> ...this which make me wonder if this might not benefit from using
> regmap.  The read/modify/write cycles are handled by regmap_update_bits()
> and there's a standard debugfs file for dumping registers.  Should save
> a bit of code I think but I'd not worry too much either way.
> 
> > +static int __init smb347_init(void)
> > +{
> > +	return i2c_add_driver(&smb347_driver);
> > +}
> > +module_init(smb347_init);
> > +
> > +static void __exit smb347_exit(void)
> > +{
> > +	i2c_del_driver(&smb347_driver);
> > +}
> > +module_exit(smb347_exit);
> 
> There's module_i2c_driver() (and similarly for SPI and platform) though
> that's definitely a nitpick.

I agree with all these comments. There wasn't any update on this
patch though. But it compiles and hopefully works, so I'm applying it
w/ some lingering hope that it'll receive attention from the submitter. :-)

Thanks!

-- 
Anton Vorontsov
Email: cbouatmailru@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/