linux-kernel - Re: [PATCH net-next] net: ipv4: Standardize prefixes for message logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Mar 2012 17:35:52 -0700
From:	Joe Perches <joe@...ches.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: ipv4: Standardize prefixes for message
 logging

On Mon, 2012-03-12 at 17:05 -0700, David Miller wrote:
> From: Joe Perches <joe@...ches.com>
> Date: Mon, 12 Mar 2012 10:03:32 -0700
> > Add #define pr_fmt(fmt) as appropriate.
> > Add "IPv4: ", "TCP: ", and "IPsec: " to appropriate files.
> > Standardize on "UDPLite: " for appropriate uses.
> > Some prefixes were previously "UDPLITE: " and "UDP-Lite: ".
[]
> Looks good, and applied,

OK.  I'll submit a similar change for net/ipv6 in awhile.

> but I left out this hunk:
 
> > diff --git a/net/ipv4/ipcomp.c b/net/ipv4/ipcomp.c
> > index 63b64c4..56d6768 100644
> > --- a/net/ipv4/ipcomp.c
> > +++ b/net/ipv4/ipcomp.c
> > @@ -13,6 +13,7 @@
> >   *   - Compression stats.
> >   *   - Adaptive compression.
> >   */
> > +
> >  #include <linux/module.h>
> >  #include <linux/err.h>
> >  #include <linux/rtnetlink.h>
> 
> As it seemed accidental, if not gratuitous.

It wasn't accidental, though I could have mentioned it
in the changelog.  Most files have a blank line between
an initial block commment and the first #include.

I just do that by habit when looking if a file could
benefit from a #define pr_fmt.

I added a similar blank line to udplite.c, but there
I also added pr_fmt.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/