linux-kernel - RE: [PATCH 2/6] ab8500_btemp: Get rid of 'enum adc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F45880696056844FA6A73F415B568C69589ECE976E@EXDCVYMBSTM006.EQ1STM.local>
Date:	Wed, 14 Mar 2012 05:25:29 +0100
From:	Arun MURTHY <arun.murthy@...ricsson.com>
To:	Anton Vorontsov <anton.vorontsov@...aro.org>
Cc:	"dwmw2@...radead.org" <dwmw2@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Karl KOMIEROWSKI <karl.komierowski@...ricsson.com>,
	Johan BJORNSTEDT <johan.bjornstedt@...ricsson.com>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>
Subject: RE: [PATCH 2/6] ab8500_btemp: Get rid of 'enum adc_therm'

> This is the same as abx500_adc_therm, but when the former is used,
> the following warning flood pops up:
> 
> drivers/power/ab8500_btemp.c: In function
> 'ab8500_btemp_batctrl_volt_to_res':
> ab8500_btemp.c:150:25: warning: comparison between 'enum
> abx500_adc_therm' and 'enum adc_therm' [-Wenum-compare]
> ab8500_btemp.c: In function 'ab8500_btemp_curr_source_enable':
> ab8500_btemp.c:212:25: warning: comparison between 'enum
> abx500_adc_therm' and 'enum adc_therm' [-Wenum-compare]
> ab8500_btemp.c:244:32: warning: comparison between 'enum
> abx500_adc_therm' and 'enum adc_therm' [-Wenum-compare]
> ab8500_btemp.c: In function 'ab8500_btemp_measure_temp':
> ab8500_btemp.c:462:25: warning: comparison between 'enum
> abx500_adc_therm' and 'enum adc_therm' [-Wenum-compare]
> ab8500_btemp.c: In function 'ab8500_btemp_id':
> ab8500_btemp.c:528:121: warning: comparison between 'enum
> abx500_adc_therm' and 'enum adc_therm' [-Wenum-compare]
> ab8500_btemp.c:551:25: warning: comparison between 'enum
> abx500_adc_therm' and 'enum adc_therm' [-Wenum-compare]
> 
> This patch fixes the issue by switching the driver to use more
> namespace-friendly enum.
> 
> Signed-off-by: Anton Vorontsov <anton.vorontsov@...aro.org>
> ---
Signed-off-by: Arun Murthy <arun.murthy@...ricsson.com>