[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHR064gzke5o4C8cg2qH1d4VuXTMmqV-sAaiOv5O650qjc01sw@mail.gmail.com>
Date: Wed, 14 Mar 2012 08:12:19 +0100
From: Corentin Chary <corentin.chary@...il.com>
To: David Rientjes <rientjes@...gle.com>
Cc: Matthew Garrett <mjg@...hat.com>,
platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [patch -next 1/2] drivers, samsung-laptop: fix initialization of
sabi_data in sabi_set_commandb
On Wed, Mar 14, 2012 at 6:59 AM, David Rientjes <rientjes@...gle.com> wrote:
> Fields d0, d1, d2, and d3 are members of an anonymous struct inside an
> anonymous union inside struct sabi_data. Initialization must be done by
> wrapping the anonymous union and structs with brackets to avoid a build
> error:
>
> drivers/platform/x86/samsung-laptop.c: In function ‘sabi_set_commandb’:
> drivers/platform/x86/samsung-laptop.c:433: error: unknown field ‘d0’ specified in initializer
> drivers/platform/x86/samsung-laptop.c:433: warning: missing braces around initializer
> drivers/platform/x86/samsung-laptop.c:433: warning: (near initialization for ‘in.<anonymous>’)
> ...
>
> Signed-off-by: David Rientjes <rientjes@...gle.com>
> ---
> drivers/platform/x86/samsung-laptop.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
> --- a/drivers/platform/x86/samsung-laptop.c
> +++ b/drivers/platform/x86/samsung-laptop.c
> @@ -430,7 +430,7 @@ exit:
> static int sabi_set_commandb(struct samsung_laptop *samsung,
> u16 command, u8 data)
> {
> - struct sabi_data in = { .d0 = 0, .d1 = 0, .d2 = 0, .d3 = 0 };
> + struct sabi_data in = { { { .d0 = 0, .d1 = 0, .d2 = 0, .d3 = 0 } } };
>
> in.data[0] = data;
> return sabi_command(samsung, command, &in, NULL);
Acked-by: Corentin Chary <corentincj@...aif.net>
David, just in case, I found this mail in my spam folder, probably
because your smtp server is not allowed to send @google.com mails.
Also, with which version of gcc is this necessary ? Old version worked
with 4.5 and 4.6.
Matthew, could you merge that one and the other directly in your tree ? Thanks
--
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists