linux-kernel - Re: [PATCH 2/2] page_alloc: Remove argument to find_zone_movable_pfns_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFPAmTTW4tYL0NP6JSpPoHkT-BxPjHHwJpJtkxQdOW_Bp=hwrA@mail.gmail.com>
Date:	Wed, 14 Mar 2012 16:14:04 +0530
From:	Kautuk Consul <consul.kautuk@...il.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mgorman@...e.de>, Tejun Heo <tj@...nel.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Minchan Kim <minchan.kim@...il.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] page_alloc: Remove argument to find_zone_movable_pfns_for_nodes

On Wed, Mar 14, 2012 at 4:12 PM, Kautuk Consul <consul.kautuk@...il.com> wrote:
> On Wed, Mar 14, 2012 at 2:17 AM, David Rientjes <rientjes@...gle.com> wrote:
>> On Tue, 13 Mar 2012, Kautuk Consul wrote:
>>
>>> The find_zone_movable_pfns_for_nodes() function does not utiilize
>>> the argument to it.
>>>
>>
>> It could, though, if we made it to do so.
>>
>>> Removing this argument from the function prototype as well as its
>>> caller, i.e. free_area_init_nodes().
>>>
>>
>> Not sure if we'd ever want it or not for other purposes, but
>> find_zone_movable_pfns_for_nodes() could easily be made to use the passed
>> in array rather than zone_movable_pfn in file scope directly.  That seems
>> to be why it took an argument in the first place.
>>
>
> No function is calling this function and I just wanted to remove the
> slight overhead of passing an
> argument which does not get used.

Sorry.. I meant : no other function oter than free_area_init_nodes()
calls this function.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/