linux-kernel - Re: [PATCH] mpt2sas: Fix hex/decimal typo in _base_sas_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120314180822.GA29954@onthe.net.au>
Date:	Thu, 15 Mar 2012 05:08:22 +1100
From:	Chris Dunlop <chris@...he.net.au>
To:	"James E.J. Bottomley" <JBottomley@...allels.com>,
	"Nandigama, Nagalakshmi" <Nagalakshmi.Nandigama@....com>,
	Kashyap Desai <kashyap.desai@....com>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	sathisha.nanjappa@...com
Subject: Re: [PATCH] mpt2sas: Fix hex/decimal typo in _base_sas_log_info()

On Wed, Mar 14, 2012 at 02:56:10PM +1100, Chris Dunlop wrote:
> The log_info constant is supposed to be IOP_LOGINFO_CODE_TASK_TERMINATED
> (see drivers/message/fusion/lsi/mpi_log_sas.h) rather than the
> non-sensical 0x1CA86D0.

Oops, I see Sathisha Nanjappa has already submitted this fix:

http://article.gmane.org/gmane.linux.scsi/73446


> Signed-off-by: Chris Dunlop <chris@...he.net.au>
> ---
>  drivers/scsi/mpt2sas/mpt2sas_base.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
> index a78036f..224ed29 100644
> --- a/drivers/scsi/mpt2sas/mpt2sas_base.c
> +++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
> @@ -657,7 +657,7 @@ _base_sas_log_info(struct MPT2SAS_ADAPTER *ioc , u32 log_info)
>  		return;
>  
>  	/* eat the loginfos associated with task aborts */
> -	if (ioc->ignore_loginfos && (log_info == 30050000 || log_info ==
> +	if (ioc->ignore_loginfos && (log_info == 0x30050000 || log_info ==
>  	    0x31140000 || log_info == 0x31130000))
>  		return;
>  
> -- 
> 1.7.0.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/