linux-kernel - Re: [PATCH] proc-ns: Use d_set_d_op() API to set dentry ops in proc_ns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1zkbjauqj.fsf@fess.ebiederm.org>
Date:	Wed, 14 Mar 2012 11:43:48 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Jesse Gross <jesse@...ira.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Pravin B Shelar <pshelar@...ira.com>,
	Justin Pettit <jpettit@...ira.com>
Subject: Re: [PATCH] proc-ns: Use d_set_d_op() API to set dentry ops in proc_ns_instantiate().

Jesse Gross <jesse@...ira.com> writes:

> From: Pravin B Shelar <pshelar@...ira.com>
>
> Use d_set_d_op() so that DCACHE_OP_* flags are set correctly which fixes ns
> cleanup path i.e. `ip netns delete `.
>
> This issue exists back to 3.0.

Acked-by: "Eric W. Biederman" <ebiederm@...ssion.com>

Jesse thanks for picking this up and giving this a push.  This is most
definitely the right fix and it most definitely solves issues.   Somehow
this fix got lost when I sent it to Linus the first time.

> CC: Eric W. Biederman <ebiederm@...ssion.com>
> Reported-by: Justin Pettit <jpettit@...ira.com>
> Signed-off-by: Pravin B Shelar <pshelar@...ira.com>
> Signed-off-by: Jesse Gross <jesse@...ira.com>
> ---
>  fs/proc/namespaces.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/proc/namespaces.c b/fs/proc/namespaces.c
> index 27da860..3551f1f 100644
> --- a/fs/proc/namespaces.c
> +++ b/fs/proc/namespaces.c
> @@ -53,7 +53,7 @@ static struct dentry *proc_ns_instantiate(struct inode *dir,
>  	ei->ns_ops    = ns_ops;
>  	ei->ns	      = ns;
>  
> -	dentry->d_op = &pid_dentry_operations;
> +	d_set_d_op(dentry, &pid_dentry_operations);
>  	d_add(dentry, inode);
>  	/* Close the race of the process dying before we return the dentry */
>  	if (pid_revalidate(dentry, NULL))
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/