linux-kernel - Re: [PATCH] tile: remove a non-existing header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F60EC8C.1040400@tilera.com>
Date:	Wed, 14 Mar 2012 15:07:56 -0400
From:	Chris Metcalf <cmetcalf@...era.com>
To:	Mauro Carvalho Chehab <mchehab@...hat.com>
CC:	<torvalds@...ux-foundation.org>,
	Linux Edac Mailing List <linux-edac@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	<stable@...nel.org>
Subject: Re: [PATCH] tile: remove a non-existing header

On 3/12/2012 10:18 AM, Mauro Carvalho Chehab wrote:
> Btw, the ./arch/tile/configs/tilepro_defconfig doesn't compile even
> with this fix. It fails at arch/tile/include/asm/atomic_64.h because
> atomic64_t is never defined, but it is used there and on other places.

I suspect you may be trying to use tilepro_defconfig with ARCH=tilegx. 
It's only valid for ARCH=tilepro, just like tilegx_defconfig is only valid
for ARCH=tilegx.  There's some #ifdefs that are supposed to catch this (in
asm-offsets.c) but it's coming too late.  I'll move it so it's before all
the #includes so at least it will be the first error that you see!

> Also, while the edac_tile driver seems to be for both Tile GX and Tilepro
> sub-archs, it is not included on tilegx_defconfig. It would make sense
> to add it there, in order to make easier for people to test/use the
> EDAC drivers.

Fixed now in Linus' tree.

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/