linux-kernel - [PATCH 11/11] dynamic_debug: init with core_initcall, not arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 Mar 2012 17:02:06 -0600
From:	jim.cromie@...il.com
To:	jbaron@...hat.com, rusty@...tcorp.com.au
Cc:	linux-kernel@...r.kernel.org, Jim Cromie <jim.cromie@...il.com>
Subject: [PATCH 11/11] dynamic_debug: init with core_initcall, not arch_initcall

From: Jim Cromie <jim.cromie@...il.com>

Initializing dynamic_debug earlier makes pr_debug useful earlier
in boot process.  For example:

    dyndbg=" module params +p"

will enable parameter processing for initcall levels after core.
Note that this is too late to enable params processing for builtin
modules, which is a significant limitation, but its still
potentially useful.

RFC: This works for me on a 64 bit desktop and i586 SBC, but is
untested on other arches.  I presume there is or was a reason
it was done with arch_initcall, maybe the constraints have changed.

Signed-off-by: Jim Cromie <jim.cromie@...il.com>
---
 lib/dynamic_debug.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 8fcead5..747245d 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -1009,7 +1009,7 @@ out_free:
 	return 0;
 }
 /* Allow early initialization for boot messages via boot param */
-arch_initcall(dynamic_debug_init);
+core_initcall(dynamic_debug_init);

 /* Debugfs setup must be done later */
 module_init(dynamic_debug_init_debugfs);
-- 
1.7.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/