linux-kernel - Re: [PATCH]: md: Initialize ctl_name field of table raid_root_table/raid_dir_table to avoid dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120314133501.14c6f7e9@notabene.brown>
Date:	Wed, 14 Mar 2012 13:35:01 +1100
From:	NeilBrown <neilb@...e.de>
To:	ebiederm@...ssion.com (Eric W. Biederman)
Cc:	qing gu <qing.gu@...cle.com>, linux-raid@...r.kernel.org,
	linux-kernel@...r.kernel.org, trivial@...nel.org
Subject: Re: [PATCH]: md: Initialize ctl_name field of table
 raid_root_table/raid_dir_table to avoid dump_trace info in debug kernel

On Tue, 13 Mar 2012 19:14:05 -0700 ebiederm@...ssion.com (Eric W. Biederman)
wrote:

> NeilBrown <neilb@...e.de> writes:
> 
> > On Mon, 12 Mar 2012 11:58:53 +0800 qing gu <qing.gu@...cle.com> wrote:
> >
> >> This patch is used to dispense trace info when system boots with debug 
> >> kernel. I have verified it on RHEL6.2 & SLES11.2. Both work fine.
> >> In the failure case, system logs that:
> >> 
> >>     /Feb 21 19:33:55 nsgbj-216-137 kernel: sysctl_check_dir: failed: /dev  ref: /dev .7

.....

> > These lines were removed in November 2009 by Eric Biederman in
> > commit 894d2491153a9f8270dbed21175d06fde4eba6c7
> >
> > So I'm not keen on adding them back without understanding the history.
> >
> > Eric:  Do we need these after all?
> 
> For the main trunk no.  The .ctl_name field no longer exists.
> 
> kernel/binary_sysctl.c is used to provide backwards compatibility with
> the old binary names.
> 
> There might be a point for doing something in -stable or someone's
> enterprise kernel if some messed up set of backports were merged.
> 
> Eric

Thanks for the quick response Eric!!

Qing: It looks like this is not an issue in mainline.
  If you want to get something fixed in SLES or RHEL, I suggest you log an
  issue in the relevant bugzillas (though I just checked SLES11-SP2, and
  it doesn't mention sysctl_check_dir at all).

NeilBrown

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)