linux-kernel - Re: [PATCH v2 1/3] radix-tree: introduce bit-optimized iterator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120314231826.3938e451.akpm@linux-foundation.org>
Date:	Wed, 14 Mar 2012 23:18:26 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Konstantin Khlebnikov <khlebnikov@...nvz.org>
Cc:	Hugh Dickins <hughd@...gle.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: [PATCH v2 1/3] radix-tree: introduce bit-optimized iterator

On Thu, 15 Mar 2012 09:51:03 +0400 Konstantin Khlebnikov <khlebnikov@...nvz.org> wrote:

> > When a c programmer sees a variable called "i", he solidly expects it
> > to have type "int".  Please choose a better name for this guy!
> > Perferably something which helps the reader understand what the
> > variable's role is.
> 
> =) Ok, I can make it "int"

This should be an unsigned type - negative values are meaningless here.

And "i" is simply a poor identifier.  A good identifier is one which
communicates the variable's role.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/