lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Mar 2012 09:09:42 +0100 From: walter harms <wharms@....de> To: Julia Lawall <Julia.Lawall@...6.fr> CC: Guan Xuetao <gxt@...c.pku.edu.cn>, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] arch/unicore32/kernel/dma.c: eliminated unneeded free_irq Am 15.03.2012 09:01, schrieb Julia Lawall: > From: Julia Lawall <Julia.Lawall@...6.fr> > > The device remains functional if the second request_irq fails, so the first > one should not be freed. > > Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr> > > --- > diff --git a/arch/unicore32/kernel/dma.c b/arch/unicore32/kernel/dma.c > index ae441bc..6184ff2 100644 > --- a/arch/unicore32/kernel/dma.c > +++ b/arch/unicore32/kernel/dma.c > @@ -172,8 +172,9 @@ int __init puv3_init_dma(void) > > ret = request_irq(IRQ_DMAERR, dma_err_handler, 0, "DMAERR", NULL); > if (ret) { > + /* the device remains function if this fails, so don't free > + the previously allocated irq */ > printk(KERN_CRIT "Can't register IRQ for DMAERR\n"); > - free_irq(IRQ_DMA, "DMA"); > return ret; > } > obviously we had the same idea ... i did not see that her it came in the moment i send my reply sorry for the noise, re, wh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists