linux-kernel - Re: [PATCH] KVM: VMX: call invvpid only when EPT is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F61BC02.6070607@redhat.com>
Date:	Thu, 15 Mar 2012 11:53:06 +0200
From:	Avi Kivity <avi@...hat.com>
To:	dave@....org
CC:	Marcelo Tosatti <mtosatti@...hat.com>,
	Sheng Yang <sheng.yang@...el.com>, KVM <kvm@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] KVM: VMX: call invvpid only when EPT is disabled

On 03/15/2012 03:44 AM, Davidlohr Bueso wrote:
> From: Davidlohr Bueso <dave@....org>
>
> With EPT enabled it is not required to explicitly run invvpid to invalidate tagged TLB entries, as
> KVM does not force vm-exits for cr3 writes and invlpg. Run invvpid only when these instructions
> are emulated and shadow pages are used.
>
> Signed-off-by: Davidlohr Bueso <dave@....org>
> ---
>  arch/x86/kvm/vmx.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 2c22fc7..51c7fb9 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -2861,12 +2861,13 @@ static void exit_lmode(struct kvm_vcpu *vcpu)
>  
>  static void vmx_flush_tlb(struct kvm_vcpu *vcpu)
>  {
> -	vpid_sync_context(to_vmx(vcpu));
>  	if (enable_ept) {
>  		if (!VALID_PAGE(vcpu->arch.mmu.root_hpa))
>  			return;
>  		ept_sync_context(construct_eptp(vcpu->arch.mmu.root_hpa));
>  	}
> +	else
> +		vpid_sync_context(to_vmx(vcpu));
>  }
>  
>  static void vmx_decache_cr0_guest_bits(struct kvm_vcpu *vcpu)

This is wrong, cr3 can still be written from host userspace.

To perform this optimization you need to separate the concept of
flushing the guest tlb and the host tlb.  I doubt it's worthwhile
though, won't the ept invalidation flush the entire tlb anyway?

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/