linux-kernel - Re: [PATCH v3 1/6] regmap: add support for 7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Mar 2012 10:44:44 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Marc Reilly <marc@...esign.com.au>
Cc:	sameo@...ux.intel.com, linux-arm-kernel@...ts.infradead.org,
	spi-devel-general@...ts.sourceforge.net, linux-i2c@...r.kernel.org,
	u.kleine-koenig@...gutronix.de, oskar@...ra.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/6] regmap: add support for 7_25 format

On Thu, Mar 15, 2012 at 07:43:05AM +1100, Marc Reilly wrote:
> This adds support for devices with 7 address bits and 25 data bits.
> The initial intended user for this are the mc13xxx mfds in spi mode.
> (The 25th data bit is actually a dummy bit)
> 
> Signed-off-by: Marc Reilly <marc@...esign.com.au>

It looks like this should be using the pad_bits parameter, though
currently we only actually support pad bytes and integer sized register
values.  Ugh.  We also have some entertainment because this device
contains a touchscreen so I imagine you want readback but devices using
odd register sizes don't do readback right now.

What I think we want to do here is use pad_bits then internally to the
API notice that reg_bits + pad_bits is a byte and therefore set up for 8
bit registers and set a new value reg_shift in the map which shifts the
register address left, either teaching the register format functions
about it or just making a new one.  This should work better from a
framework point of view.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)