linux-kernel - Re: [PATCH] regulator: notify sysfs when voltage is set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120315144708.GM3138@opensource.wolfsonmicro.com>
Date:	Thu, 15 Mar 2012 14:47:08 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Simon Horman <horms@...ge.net.au>
Cc:	Liam Girdwood <lrg@...com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: notify sysfs when voltage is set

On Thu, Mar 15, 2012 at 11:26:58PM +0900, Simon Horman wrote:
> On Thu, Mar 15, 2012 at 12:46:31PM +0000, Mark Brown wrote:

> > I notice that we don't generate similar events for cpufreq...  what are
> > the performance implications from firing off udev (which isn't free)
> > every time we scale the CPU frequency?  It feels like this might be
> > disruptive, especially with a governor like ondemand which responds to
> > system load.

> that is a good point and to be honest not one that I had considered.  For
> the use-case that I have in mind, which is basically to log voltage changes
> over time, it may be acceptable to rate-limit notifications somehow. But at
> that point I may be better off just polling.

Hrm, if you're doing logging then we do already have tracepoints defined
for voltage changes - could you have your application work with those
instead of sysfs?  One of the applications of tracepoints is flight
recorder style system monitoring.

> Out of interest, how often can ondemand potentially change the voltage?

Depends on how slow it thinks frequency changes are.  I'm not so worried
about the performance impact from that point of view, I'm more worried
about what happens when we lower the clock frequency and generate a
sysfs event causing userspace to wake up and start doing stuff.  It'd be
bad if ondemand (or another dynamic governor) noticed that the system
got more busy again and responded by ramping the frequency...

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)