linux-kernel - Re: [PATCH] power_supply: Convert power_supply i2c drivers to module_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 15 Mar 2012 21:15:38 +0400
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Ryan Mallon <rmallon@...il.com>,
	Woogyom Kim <milo.kim@...com>,
	Daniel Jeong <daniel.jeong@...com>,
	Minkyu Kang <mk7.kang@...sung.com>,
	MyungJoo Ham <myungjoo.ham@...sung.com>,
	Rhyland Klein <rklein@...dia.com>,
	Peter Edwards <sweetlilmre@...il.com>
Subject: Re: [PATCH] power_supply: Convert power_supply i2c drivers to
 module_i2c_driver

On Sat, Jan 21, 2012 at 02:42:54PM +0800, Axel Lin wrote:
> Factor out some boilerplate code for i2c driver registration
> into module_i2c_driver.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> Cc: Ryan Mallon <rmallon@...il.com>
> Cc: Woogyom Kim <milo.kim@...com>
> Cc: Daniel Jeong <daniel.jeong@...com>
> Cc: Minkyu Kang <mk7.kang@...sung.com>
> Cc: MyungJoo Ham <myungjoo.ham@...sung.com>
> Cc: Rhyland Klein <rklein@...dia.com>
> Cc: Peter Edwards <sweetlilmre@...il.com>
> ---
>  drivers/power/ds2782_battery.c   |   12 +-----------
>  drivers/power/lp8727_charger.c   |   13 +------------
>  drivers/power/max17040_battery.c |   12 +-----------
>  drivers/power/max17042_battery.c |   12 +-----------
>  drivers/power/sbs-battery.c      |   12 +-----------
>  drivers/power/z2_battery.c       |   13 +------------
>  6 files changed, 6 insertions(+), 68 deletions(-)
> 
> diff --git a/drivers/power/ds2782_battery.c b/drivers/power/ds2782_battery.c
> index bfbce5d..6e3d76a 100644
> --- a/drivers/power/ds2782_battery.c
> +++ b/drivers/power/ds2782_battery.c
> @@ -404,17 +404,7 @@ static struct i2c_driver ds278x_battery_driver = {
>  	.id_table	= ds278x_id,
>  };
>  

Cosmetic nit: I don't think that there should be an empty line.
I.e. it should be just as we do with MODULE_DEVICE_TABLE and
other macros:

static const struct i2c_device_id .. = {
	...
};
MODULE_DEVICE_TABLE(...)

static struct i2c_driver ... = {
	...
};
module_i2c_driver(...);

I fixed it up and applied the patch. Thanks!

-- 
Anton Vorontsov
Email: cbouatmailru@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/