lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Mar 2012 15:49:41 -0700 From: Randy Dunlap <rdunlap@...otime.net> To: Jussi Kivilinna <jussi.kivilinna@...et.fi> CC: Herbert Xu <herbert@...dor.apana.org.au>, Stephen Rothwell <sfr@...b.auug.org.au>, linux-next@...r.kernel.org, linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/2] crypto: twofish-x86_64-3way - module init/exit functions should be static On 03/15/2012 01:11 PM, Jussi Kivilinna wrote: > This caused conflict with camellia-x86_64 when compiled into kernel, same > function names and not static. > > Reported-by: Randy Dunlap <rdunlap@...otime.net> > Signed-off-by: Jussi Kivilinna <jussi.kivilinna@...et.fi> Acked-by: Randy Dunlap <rdunlap@...otime.net> Thanks. > --- > arch/x86/crypto/twofish_glue_3way.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/crypto/twofish_glue_3way.c b/arch/x86/crypto/twofish_glue_3way.c > index 408fc0c..922ab24 100644 > --- a/arch/x86/crypto/twofish_glue_3way.c > +++ b/arch/x86/crypto/twofish_glue_3way.c > @@ -668,7 +668,7 @@ static int force; > module_param(force, int, 0); > MODULE_PARM_DESC(force, "Force module load, ignore CPU blacklist"); > > -int __init init(void) > +static int __init init(void) > { > if (!force && is_blacklisted_cpu()) { > printk(KERN_INFO > @@ -681,7 +681,7 @@ int __init init(void) > return crypto_register_algs(tf_algs, ARRAY_SIZE(tf_algs)); > } > > -void __exit fini(void) > +static void __exit fini(void) > { > crypto_unregister_algs(tf_algs, ARRAY_SIZE(tf_algs)); > } > -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists