linux-kernel - Re: [PATCH] scsi: qla2xxx: fix section mismatch in linux-next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1331854276.10203.143.camel@haakon2.linux-iscsi.org>
Date:	Thu, 15 Mar 2012 16:31:16 -0700
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	Gerard Snitselaar <dev@...tselaar.org>
Cc:	andrew.vasquez@...gic.com, linux-driver@...gic.com,
	JBottomley@...allels.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	target-devel <target-devel@...r.kernel.org>
Subject: Re: [PATCH] scsi: qla2xxx: fix section mismatch in linux-next

On Thu, 2012-03-15 at 14:40 -0700, Gerard Snitselaar wrote:
> qla_tgt_exit() is annotated __exit , but called in
> qla2x00_module_init().
> 
> Signed-off-by: Gerard Snitselaar <dev@...tselaar.org>
> ---
>  drivers/scsi/qla2xxx/qla_target.c |    2 +-
>  drivers/scsi/qla2xxx/qla_target.h |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

Hi Gerard,

> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index 6d6f1cf..699d16e 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -4730,7 +4730,7 @@ out:
>  	return ret;
>  }
>  
> -void __exit qla_tgt_exit(void)
> +void qla_tgt_exit(void)
>  {
>  	destroy_workqueue(qla_tgt_wq);
>  	mempool_destroy(qla_tgt_mgmt_cmd_mempool);
> diff --git a/drivers/scsi/qla2xxx/qla_target.h b/drivers/scsi/qla2xxx/qla_target.h
> index db6b399..b9d0aa1 100644
> --- a/drivers/scsi/qla2xxx/qla_target.h
> +++ b/drivers/scsi/qla2xxx/qla_target.h
> @@ -934,7 +934,7 @@ extern void qla_tgt_fc_port_deleted(struct scsi_qla_host *, fc_port_t *);
>  extern void qla_tgt_set_mode(struct scsi_qla_host *ha);
>  extern void qla_tgt_clear_mode(struct scsi_qla_host *ha);
>  extern int __init qla_tgt_init(void);
> -extern void __exit qla_tgt_exit(void);
> +extern void qla_tgt_exit(void);
>  
>  static inline bool qla_tgt_mode_enabled(struct scsi_qla_host *ha)
>  {

This looks fine.  Applied to lio-core, and will get this fixed up in
target-pending/for-next-merge shortly.

Thanks for your patch!

--nab




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/