linux-kernel - Re: [PATCH] staging: vme: fix section mismatches in linux-next 20120314

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F631953.1090701@ge.com>
Date:	Fri, 16 Mar 2012 10:43:31 +0000
From:	Martyn Welch <martyn.welch@...com>
To:	Gerard Snitselaar <dev@...tselaar.org>
CC:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vme: fix section mismatches in linux-next 20120314

On 15/03/12 08:50, Gerard Snitselaar wrote:
> pio2_gpio_init() annotated with __init, but called by pio2_probe()
> which is annotated __devinit. pio2_gpio_exit() is annotated __exit,
> but is called by pio2_probe() and by pio2_remove() which is annotated
> __devexit.
> 
> Signed-off-by: Gerard Snitselaar <dev@...tselaar.org>

I was just about to ack that and realised that Greg's already applied it :-)

Good catch, thanks,

Martyn

> ---
>  drivers/staging/vme/devices/vme_pio2.h      |    4 ++--
>  drivers/staging/vme/devices/vme_pio2_gpio.c |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/vme/devices/vme_pio2.h b/drivers/staging/vme/devices/vme_pio2.h
> index 3c59313..72d9ce0 100644
> --- a/drivers/staging/vme/devices/vme_pio2.h
> +++ b/drivers/staging/vme/devices/vme_pio2.h
> @@ -243,7 +243,7 @@ struct pio2_card {
>  int pio2_cntr_reset(struct pio2_card *);
>  
>  int pio2_gpio_reset(struct pio2_card *);
> -int __init pio2_gpio_init(struct pio2_card *);
> -void __exit pio2_gpio_exit(struct pio2_card *);
> +int __devinit pio2_gpio_init(struct pio2_card *);
> +void pio2_gpio_exit(struct pio2_card *);
>  
>  #endif /* _VME_PIO2_H_ */
> diff --git a/drivers/staging/vme/devices/vme_pio2_gpio.c b/drivers/staging/vme/devices/vme_pio2_gpio.c
> index dc837de..8584849 100644
> --- a/drivers/staging/vme/devices/vme_pio2_gpio.c
> +++ b/drivers/staging/vme/devices/vme_pio2_gpio.c
> @@ -187,7 +187,7 @@ int pio2_gpio_reset(struct pio2_card *card)
>  	return 0;
>  }
>  
> -int __init pio2_gpio_init(struct pio2_card *card)
> +int __devinit pio2_gpio_init(struct pio2_card *card)
>  {
>  	int retval = 0;
>  	char *label;
> @@ -220,7 +220,7 @@ int __init pio2_gpio_init(struct pio2_card *card)
>  	return retval;
>  };
>  
> -void __exit pio2_gpio_exit(struct pio2_card *card)
> +void pio2_gpio_exit(struct pio2_card *card)
>  {
>  	const char *label = card->gc.label;
>  


-- 
Martyn Welch (Lead Software Engineer)  | Registered in England and Wales
GE Intelligent Platforms               | (3828642) at 100 Barbirolli Square
T +44(0)1327322748                     | Manchester, M2 3AB
E martyn.welch@...com                  | VAT:GB 927559189
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/