linux-kernel - Re: [PATCH] ti-st: Enhange logging for Shared Transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Mar 2012 17:35:23 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Mircea Gherzan <mgherzan@...il.com>
Cc:	alexandrasava18@...il.com, pavan_savoy@...com,
	daniel.baluta@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ti-st: Enhange logging for Shared Transport - TI driver

On Fri, Mar 16, 2012 at 01:30:43AM +0100, Mircea Gherzan wrote:
> 
> This is what I get now (with no debug) when loading the btwilink module
> that uses ti-st:
> 
> [  129.567382] (stk) :change remote baud rate command in firmware
> [  129.573577] (stk) :skipping the wait event of change remote baud
> 
> This is:
>  1. too "verbose" => these 2 prints should belong to debug
>  2. poorly formated
>  3. not telling me which driver generated this output
>  4. not giving me the version of the firmware that was loaded.
> 
> To address 2 and 3, please remove the the "(stc)" / "(stk)" prefixes and
> use instead the quite widespread prefix KBUILD_MODNAME ": "

No, just use the proper dev_*() functions instead, it will tell you
exactly what driver and device emitted the message, that is what it is
there for.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/