linux-kernel - RE: [Patch]Fix reason_str of pstore so that it can work correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5C4C569E8A4B9B42A84A977CF070A35B2E32064B51@USINDEVS01.corp.hds.com>
Date:	Fri, 16 Mar 2012 09:38:00 -0400
From:	Seiji Aguchi <seiji.aguchi@....com>
To:	Adrian Hunter <adrian.hunter@...el.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Luck, Tony (tony.luck@...el.com)" <tony.luck@...el.com>,
	"Chen Gong (gong.chen@...ux.intel.com)" <gong.chen@...ux.intel.com>,
	"Matthew Garrett (mjg@...hat.com)" <mjg@...hat.com>,
	"dzickus@...hat.com" <dzickus@...hat.com>,
	"dle-develop@...ts.sourceforge.net" 
	<dle-develop@...ts.sourceforge.net>,
	Satoru Moriya <satoru.moriya@....com>
Subject: RE: [Patch]Fix reason_str of pstore so that it can work correctly

Hi,

Thank you for reviewing my patch.
I will update it in accordance with your comment.

Seiji

> It would be better to make it so it would not break e.g.
> 
> static const char *get_reason_str(enum kmsg_dump_reason reason) {
> 	switch (reason) {
> 	KMSG_DUMP_PANIC:
> 		return "Panic";
> 	KMSG_DUMP_OOPS:
> 		return "Oops";
> 	KMSG_DUMP_EMERG:
> 		return "Emergency";
> 	KMSG_DUMP_RESTART:
> 		return "Restart";
> 	KMSG_DUMP_HALT:
> 		return "Halt";
> 	KMSG_DUMP_POWEROFF:
> 		return "Poweroff";
> 	default:
> 		return "Unknown";
> 	}
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/