| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1331907517-3985-2-git-send-email-matt@console-pimps.org> Date: Fri, 16 Mar 2012 14:18:35 +0000 From: Matt Fleming <matt@...sole-pimps.org> To: "H. Peter Anvin" <hpa@...or.com> Cc: Matthew Garret <mjg@...hat.com>, Matt Fleming <matt.fleming@...el.com>, linux-kernel@...r.kernel.org, x86@...nel.org Subject: [PATCH 1/3] x86, efi: Only close open files in error path From: Matt Fleming <matt.fleming@...el.com> The loop at the 'close_handles' label in handle_ramdisks() should be using 'i', which represents the number of initrd files that were successfully opened, not 'nr_initrds' which is the number of initrd= arguments passed on the command line. Currently, if we execute the loop to close all file handles and we failed to open any initrds we'll try to call the close function on a garbage pointer, causing the machine to hang. Cc: H. Peter Anvin <hpa@...or.com> Cc: Matthew Garrett <mjg@...hat.com> Signed-off-by: Matt Fleming <matt.fleming@...el.com> --- arch/x86/boot/compressed/eboot.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c index fec216f..fb810ce 100644 --- a/arch/x86/boot/compressed/eboot.c +++ b/arch/x86/boot/compressed/eboot.c @@ -674,7 +674,7 @@ free_initrd_total: low_free(initrd_total, initrd_addr); close_handles: - for (k = j; k < nr_initrds; k++) + for (k = j; k < i; k++) efi_call_phys1(fh->close, initrds[k].handle); free_initrds: efi_call_phys1(sys_table->boottime->free_pool, initrds); -- 1.7.4.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists