linux-kernel - Re: [RFC PATCH 0/9] Introduce irq_remap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 15 Mar 2012 17:51:04 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	Joerg Roedel <joerg.roedel@....com>
Cc:	iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
	David Woodhouse <dwmw2@...radead.org>,
	Alex Williamson <alex.williamson@...hat.com>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Suresh Siddha <suresh.b.siddha@...el.com>
Subject: Re: [RFC PATCH 0/9] Introduce irq_remap_ops to x86

On Thu, Mar 15, 2012 at 10:39 AM, Joerg Roedel <joerg.roedel@....com> wrote:
> Hi,
>
> in order to implement interrupt remapping using the AMD IOMMU I did some
> refactoring of the current Intel-specific interrupt remapping code. The
> result is posted for comments in this patch-set.
>
> The patch-set basically removes the Intel-specific calls from the X86
> apic and io-apic code and replaces all of them with helper functions
> that use the irq_remap_ops to hook into an implementation specific
> implementation.
>
> I have done basic testing on this patch-set on a VT-d machine with
> interrupt remapping and found no regression so far. But as usual this
> doesn't mean that there is none ;-)
>
> Anyway, since I am on vacation soon I sent out these patches to receive
> all kinds of comments so that I can start over to add the AMD part when
> I am back.
>
> Thanks,
>
>        Joerg
>
> Diffstat:
>
>  arch/ia64/include/asm/intr_remapping.h |    4 +
>  arch/x86/include/asm/intr_remapping.h  |  101 +++
>  arch/x86/include/asm/irq_remapping.h   |   45 --
>  arch/x86/kernel/apic/apic.c            |   20 +-
>  arch/x86/kernel/apic/io_apic.c         |  276 ++-------
>  drivers/iommu/Makefile                 |    2 +-
>  drivers/iommu/amd_iommu_init.c         |  123 +++--
>  drivers/iommu/dmar.c                   |    1 +
>  drivers/iommu/intel-iommu.c            |    1 +
>  drivers/iommu/intel_intr_remapping.c   | 1065 ++++++++++++++++++++++++++++++++
>  drivers/iommu/intr_remapping.c         |  810 +++----------------------
>  drivers/iommu/intr_remapping.h         |   97 +++-
>  include/linux/amd-iommu.h              |    2 +-
>  include/linux/dmar.h                   |   85 ---
>  14 files changed, 1469 insertions(+), 1163 deletions(-)

Yes, it is good clean up for ioapic.c at least.

Acked-by: Yinghai Lu <yinghai@...nel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/