| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4F635DBF.7000603@gmail.com>
Date: Fri, 16 Mar 2012 08:35:27 -0700
From: "Justin P. Mattock" <justinmattock@...il.com>
To: "Justin P. Mattock" <justinmattock@...il.com>
CC: trivial@...nel.org, linux-kernel@...r.kernel.org,
gregkh@...uxfoundation.org, linux-media@...r.kernel.org,
marauder@...cali.it
Subject: Re: [PATCH V2]NEXT:drivers:staging:media Fix comments and some typos
in staging/media/*
before I forget about this patch, what was the status of this one?
On 03/06/2012 06:55 AM, Justin P. Mattock wrote:
> From: "Justin P. Mattock"<justinmattock@...il.com>
>
> linux-next:
> I like to spend some time reading code, in doing so I have found some typos in some of the comments.
> The patch below fixes what I have found.
>
> Signed-off-by: Justin P. Mattock<justinmattock@...il.com>
>
> ---
> drivers/staging/media/Kconfig | 2 +-
> drivers/staging/media/as102/as102_drv.c | 2 +-
> drivers/staging/media/as102/as102_fe.c | 4 ++--
> drivers/staging/media/go7007/go7007-v4l2.c | 8 ++++----
> drivers/staging/media/lirc/lirc_serial.c | 2 +-
> drivers/staging/media/solo6x10/Kconfig | 2 +-
> 6 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/media/Kconfig b/drivers/staging/media/Kconfig
> index 7e5caa3..4f4b7d6 100644
> --- a/drivers/staging/media/Kconfig
> +++ b/drivers/staging/media/Kconfig
> @@ -6,7 +6,7 @@ menuconfig STAGING_MEDIA
> don't have the "normal" Linux kernel quality level.
> Most of them don't follow properly the V4L, DVB and/or RC API's,
> so, they won't likely work fine with the existing applications.
> - That also means that, one fixed, their API's will change to match
> + That also means that, once fixed, their API's will change to match
> the existing ones.
>
> If you wish to work on these drivers, to help improve them, or
> diff --git a/drivers/staging/media/as102/as102_drv.c b/drivers/staging/media/as102/as102_drv.c
> index aae0505..ea4f992 100644
> --- a/drivers/staging/media/as102/as102_drv.c
> +++ b/drivers/staging/media/as102/as102_drv.c
> @@ -27,7 +27,7 @@
> #include<linux/uaccess.h>
> #include<linux/usb.h>
>
> -/* header file for Usb device driver*/
> +/* header file for usb device driver*/
> #include "as102_drv.h"
> #include "as102_fw.h"
> #include "dvbdev.h"
> diff --git a/drivers/staging/media/as102/as102_fe.c b/drivers/staging/media/as102/as102_fe.c
> index bdc5a38..57daa8c 100644
> --- a/drivers/staging/media/as102/as102_fe.c
> +++ b/drivers/staging/media/as102/as102_fe.c
> @@ -337,7 +337,7 @@ int as102_dvb_register_fe(struct as102_dev_t *as102_dev,
> strncpy(dvb_fe->ops.info.name, as102_dev->name,
> sizeof(dvb_fe->ops.info.name));
>
> - /* register dbvb frontend */
> + /* register dvb frontend */
> errno = dvb_register_frontend(dvb_adap, dvb_fe);
> if (errno == 0)
> dvb_fe->tuner_priv = as102_dev;
> @@ -349,7 +349,7 @@ static void as10x_fe_copy_tps_parameters(struct dtv_frontend_properties *fe_tps,
> struct as10x_tps *as10x_tps)
> {
>
> - /* extract consteallation */
> + /* extract constellation */
> switch (as10x_tps->modulation) {
> case CONST_QPSK:
> fe_tps->modulation = QPSK;
> diff --git a/drivers/staging/media/go7007/go7007-v4l2.c b/drivers/staging/media/go7007/go7007-v4l2.c
> index 2b27d8d..f916586 100644
> --- a/drivers/staging/media/go7007/go7007-v4l2.c
> +++ b/drivers/staging/media/go7007/go7007-v4l2.c
> @@ -1050,15 +1050,15 @@ static int vidioc_s_parm(struct file *filp, void *priv,
> return 0;
> }
>
> -/* VIDIOC_ENUMSTD on go7007 were used for enumberating the supported fps and
> +/* VIDIOC_ENUMSTD on go7007 were used for enumerating the supported fps and
> its resolution, when the device is not connected to TV.
> - This were an API abuse, probably used by the lack of specific IOCTL's to
> - enumberate it, by the time the driver were written.
> + This is were an API abuse, probably used by the lack of specific IOCTL's to
> + enumerate it, by the time the driver was written.
>
> However, since kernel 2.6.19, two new ioctls (VIDIOC_ENUM_FRAMEINTERVALS
> and VIDIOC_ENUM_FRAMESIZES) were added for this purpose.
>
> - The two functions bellow implements the newer ioctls
> + The two functions below implement the newer ioctls
> */
> static int vidioc_enum_framesizes(struct file *filp, void *priv,
> struct v4l2_frmsizeenum *fsize)
> diff --git a/drivers/staging/media/lirc/lirc_serial.c b/drivers/staging/media/lirc/lirc_serial.c
> index 8dd8897..97352cf 100644
> --- a/drivers/staging/media/lirc/lirc_serial.c
> +++ b/drivers/staging/media/lirc/lirc_serial.c
> @@ -1282,7 +1282,7 @@ MODULE_PARM_DESC(iommap, "physical base for memory mapped I/O"
> /*
> * some architectures (e.g. intel xscale) align the 8bit serial registers
> * on 32bit word boundaries.
> - * See linux-kernel/serial/8250.c serial_in()/out()
> + * See linux-kernel/drivers/tty/serial/8250/8250.c serial_in()/out()
> */
> module_param(ioshift, int, S_IRUGO);
> MODULE_PARM_DESC(ioshift, "shift I/O register offset (0 = no shift)");
> diff --git a/drivers/staging/media/solo6x10/Kconfig b/drivers/staging/media/solo6x10/Kconfig
> index 03dcac4..63352de 100644
> --- a/drivers/staging/media/solo6x10/Kconfig
> +++ b/drivers/staging/media/solo6x10/Kconfig
> @@ -5,4 +5,4 @@ config SOLO6X10
> select SND_PCM
> ---help---
> This driver supports the Softlogic based MPEG-4 and h.264 codec
> - codec cards.
> + cards.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists