lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Mar 2012 09:29:01 -0700 From: Joe Perches <joe@...ches.com> To: David Daney <david.daney@...ium.com> Cc: Theodore Ts'o <tytso@....edu>, Andreas Dilger <adilger.kernel@...ger.ca>, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/9] ext4: Add -DDEBUG to Makefile On Fri, 2012-03-16 at 09:03 -0700, David Daney wrote: > On 03/15/2012 05:07 PM, Joe Perches wrote: > > Add -DDEBUG to enable future use of pr_debug. > > No changes to objects as no DEBUG uses currently exist. [] > > diff --git a/fs/ext4/Makefile b/fs/ext4/Makefile [] > > +ccflags-$(CONFIG_EXT4_FS) := -DDEBUG > In many other susbsystems/drivers, the definition of DEBUG is gated by a > separate Kconfig symbol used to select debugging just for that > susbsystem/driver (see CONFIG_MMC_DEBUG for example). > > Why aren't you doing the same here? It can be done later with an additional symbol if desired. For now the current code uses printk(KERN_DEBUG and a straight conversion to pr_debug would eliminate the KERN_DEBUG the output. pr_debug without #define DEBUG or dynamic_debug is compiled away to nothing. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists