| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <201203161732.17246.oliver@neukum.org> Date: Fri, 16 Mar 2012 17:32:17 +0100 From: Oliver Neukum <oliver@...kum.org> To: santosh nayak <santoshprasadnayak@...il.com> Cc: mchehab@...radead.org, gregkh@...uxfoundation.org, khoroshilov@...ras.ru, linux-media@...r.kernel.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH] [media] staging: Return -EINTR in s2250_probe() if fails to get lock. Am Freitag, 16. März 2012, 17:23:58 schrieb santosh nayak: > From: Santosh Nayak <santoshprasadnayak@...il.com> > > In s2250_probe(), If locking attempt is interrupted by a signal then > it should return -EINTR after unregistering audio device and making free > the allocated memory. > > At present, if locking is interrupted by signal it will display message > "initialized successfully" and return success. This is wrong. Indeed there's a lot wrong here. The idea of having an interruptible sleep in probe() is arcane. You need a very, very, very good reason for that. The sane fix is using an uninterruptable sleep here. Second, while you are at it, fix the error case for no initialization due to a failing kmalloc(). You need to return -ENOMEM. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists