linux-kernel - Re: [PATCH v3 2/2] input: add driver support for MAX8997-haptic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120316174802.GI20524@sortiz-mobl>
Date:	Fri, 16 Mar 2012 18:48:02 +0100
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Chanwoo Choi <cw00.choi@...sung.com>, linux-input@...r.kernel.org,
	broonie@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org,
	kyungmin.park@...sung.com, myungjoo.ham@...sung.com
Subject: Re: [PATCH v3 2/2] input: add driver support for MAX8997-haptic

Hi Dmitry,

On Wed, Mar 14, 2012 at 08:48:28AM -0700, Dmitry Torokhov wrote:
> On Wed, Mar 14, 2012 at 11:47:42PM +0900, Chanwoo Choi wrote:
> > Hi Dmitry,
> > 
> > > This is not proper locking between playing effect and suspend. Now that
> > > you are using workqueue you need to synchronize access with it, not with
> > > play_effect method.
> > > 
> > > Does the following patch work for you?
> > > 
> > 
> > Your patch is worked on TRATS board based on EXYNOS4210 but, you should
> > apply following patch because 'chip->enabled' is used on
> > max8997_haptic_configure() function to enable/disable haptic motor.
> 
> OK, excellent. I'll pick up this fix and apply the driver for 3.4 queue,
> thanks!
Your patch depends on the MFD changes Choi sent along the input driver. I
think it would make more sense for me to take it. What do you think ?

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/