linux-kernel - Re: [PATCH V2] Enhance logging for Shared Transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1331921203.11368.4.camel@joe2Laptop>
Date:	Fri, 16 Mar 2012 11:06:43 -0700
From:	Joe Perches <joe@...ches.com>
To:	alexandrasava18@...il.com
Cc:	gregkh@...uxfoundation.org, pavan_savoy@...com, mgherzan@...il.com,
	daniel.baluta@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] Enhance logging for Shared Transport - TI driver

On Fri, 2012-03-16 at 19:58 +0200, alexandrasava18@...il.com wrote:
> From: Alexandra Sava <alexandrasava18@...il.com>
> * reduced verbosity
> * replaced pr_* with dev_* where possible

pr_<level> and dev_<level> formats should end in with
a "\n" newline.

> diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c
[]
> @@ -19,7 +19,6 @@
>   *
>   */
>  
> -#define pr_fmt(fmt)	"(stc): " fmt

It'd be useful to keep the #define pr_fmt
perhaps as
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
for each file so that the pr_<level> uses
are prefixed by subsystem.

> @@ -122,12 +119,12 @@ void st_send_frame(unsigned char chnl_id, struct st_data_s *st_gdata)
>  			(st_gdata->list[chnl_id]->recv
>  			(st_gdata->list[chnl_id]->priv_data, st_gdata->rx_skb)
>  			     != 0)) {
> -			pr_err(" proto stack %d's ->recv failed", chnl_id);
> +			pr_err("proto stack %d's ->recv failed", chnl_id);

			pr_err(proto stack %d's ->recv failed\n", chnl_id);

>  			kfree_skb(st_gdata->rx_skb);
>  			return;
>  		}
>  	} else {
> -		pr_err(" proto stack %d's ->recv null", chnl_id);
> +		pr_err("proto stack %d's ->recv null", chnl_id);

		pr_err("proto stack %d's ->recv null\n", chnl_id);
etc...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/