linux-kernel - Re: [PATCH 1/4] mfd/ab8500: don't use mutex_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120316184609.GN20524@sortiz-mobl>
Date:	Fri, 16 Mar 2012 19:46:09 +0100
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Linus Walleij <linus.walleij@...ricsson.com>
Cc:	linux-kernel@...r.kernel.org,
	Rabin Vincent <rabin.vincent@...ricsson.com>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH 1/4] mfd/ab8500: don't use mutex_lock_interruptible

Hi Linus,

On Thu, Mar 08, 2012 at 02:01:46PM +0100, Linus Walleij wrote:
> From: Rabin Vincent <rabin.vincent@...ricsson.com>
> 
> This disadvantage of having it interruptible is that it would
> appear to work OK in most situations, but in the rare case
> that this call does fail, it can lead to misconfiguration
> of the AB, such as a regulator not being turned off and
> leading to a platform power consumption increase.
> 
> There's no real benefit to having this interruptible.
> 
> Make it a plain mutex_lock. The non-interruptability matches
> other low-level I/O functions such as SPI and I2C.
> 
> Signed-off-by: Rabin Vincent <rabin.vincent@...ricsson.com>
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> ---
>  drivers/mfd/ab8500-core.c |   12 +++---------
>  1 files changed, 3 insertions(+), 9 deletions(-)
All 4 patches applied, thanks.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/