linux-kernel - Re: [PATCHv2 3/5] cpuidle: add support for states that affect multiple cpus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F629CC5.60402@linux.intel.com>
Date:	Thu, 15 Mar 2012 18:52:05 -0700
From:	Arjan van de Ven <arjan@...ux.intel.com>
To:	Colin Cross <ccross@...roid.com>
CC:	Kevin Hilman <khilman@...com>, linux-kernel@...r.kernel.org,
	Len Brown <len.brown@...el.com>,
	Trinabh Gupta <g.trinabh@...il.com>,
	Kay Sievers <kay.sievers@...y.org>,
	Deepthi Dharwar <deepthi@...ux.vnet.ibm.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Amit Kucheria <amit.kucheria@...aro.org>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
	Santosh Shilimkar <santosh.shilimkar@...com>,
	linux-pm@...ts.linux-foundation.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCHv2 3/5] cpuidle: add support for states that affect multiple
 cpus

On 3/15/2012 5:20 PM, Colin Cross wrote:
> Oops, dropped the atomic_dec when I merged from two separate functions
> for up and down to a single function that takes a bool.

generally in Linux we tend to not like "multiplexer" common functions
like this.

my suggestion: make your current function a __ prefixed one, then
provide 2 small inlines that call the __ one...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/