linux-kernel - Re: [PATCH v3 2/2] input: add driver support for MAX8997-haptic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120316185626.GO20524@sortiz-mobl>
Date:	Fri, 16 Mar 2012 19:56:26 +0100
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Chanwoo Choi <cw00.choi@...sung.com>, linux-input@...r.kernel.org,
	broonie@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org,
	kyungmin.park@...sung.com, myungjoo.ham@...sung.com
Subject: Re: [PATCH v3 2/2] input: add driver support for MAX8997-haptic

Hi Dmitry,

On Fri, Mar 16, 2012 at 10:55:24AM -0700, Dmitry Torokhov wrote:
> > > OK, excellent. I'll pick up this fix and apply the driver for 3.4 queue,
> > > thanks!
> > Your patch depends on the MFD changes Choi sent along the input driver. I
> > think it would make more sense for me to take it. What do you think ?
> 
> I think that splitting required platform data definitions from the
> driver into separate patch is quite pointless. 
Hmm, you're right on this one.

> I often see a driver
> split in 3+ patches - headers, the driver itself and Kconfig/makefile
> changes and I wonder what made them do it...
> 
> Anyway, below is the consolidated patch I was going to apply to my tree,
> but if you want to go through yours - feel free to apply it.
No, I think it makes sense for you to take it. Add my:
Acked-by: Samuel Ortiz <sameo@...ux.intel.com>

if you feel it's needed.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/