linux-kernel - Re: [PATCH 02/11] sgi-xp: Use lockdep_assert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120316191128.GH4958@sgi.com>
Date:	Fri, 16 Mar 2012 14:11:28 -0500
From:	Robin Holt <holt@....com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
	holt@....com
Subject: Re: [PATCH 02/11] sgi-xp: Use lockdep_assert_held

On Fri, Mar 16, 2012 at 12:00:55PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@...ux.intel.com>
> 
> !spin_is_locked() is always true on a up build, so cannot
> be used for assert.  Replace with lockdep_assert_held.
> 
> I realize UP builds are not very likely for this driver,
> but it's still better to fix it.

Acked-by: Robin Holt <holt@....com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/