linux-kernel - Re: [PATCH] Replace IS_ENABLED(CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120316032239.GA31524@thor.bakeyournoodle.com>
Date:	Fri, 16 Mar 2012 14:22:40 +1100
From:	Tony Breeds <tony@...eyournoodle.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	Robert Love <robert.w.love@...el.com>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	"David S. Miller" <davem@...emloft.net>, devel@...n-fcoe.org,
	netdev@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Replace IS_ENABLED(CONFIG_FCOE) in linux/netdevice.h

On Fri, Mar 16, 2012 at 12:55:45AM +0000, Ben Hutchings wrote:
> On Fri, 2012-03-16 at 11:30 +1100, Tony Breeds wrote:
> > On platforms that (or configs that do not have PCI support building any
> > code that includes linux/netdevice.h we see the following warnings:
> > 
> > include/linux/netdevice.h:964:1: warning: "__enabled_CONFIG_FCOE" is not defined [-Wundef]
> > include/linux/netdevice.h:964:1: warning: "__enabled_CONFIG_FCOE_MODULE" is not defined [-Wundef]
> > 
> > In the case of this file we can trivially fallback to the old school
> >  #if defined(...) syntax.
> [...]
> 
> The script that generates those symbols should be fixed instead.

Sorry all, Yes this patch is bogus.

The platform was seeing this error wasn't sourceing
drivers/scsi/Kconfig, so those symbols will never be defined.  I imagine
that's pretty rare.

Yours Tony

Content of type "application/pgp-signature" skipped