linux-kernel - Re: [PATCHv2 3/3] simple_open: Automatically convert to simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120316164911.dbc089de.akpm@linux-foundation.org>
Date:	Fri, 16 Mar 2012 16:49:11 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Julia Lawall <Julia.Lawall@...6.fr>
Subject: Re: [PATCHv2 3/3] simple_open: Automatically convert to
 simple_open()

On Tue, 13 Mar 2012 02:46:28 -0700
Stephen Boyd <sboyd@...eaurora.org> wrote:

> Many users of debugfs copy the implementation of default_open()
> when they want to support a custom read/write function op. This
> leads to a proliferation of the default_open() implementation
> across the entire tree. Now that the common implementation has
> been consolidated into libfs we can replace all the users of this
> function with simple_open().
> 
>
> ...
>
> --- a/drivers/net/wireless/wl12xx/debugfs.c
> +++ b/drivers/net/wireless/wl12xx/debugfs.c
>

This broke.

I'm hitting quite a lot of build errors from this patch.  I'm not
confident that I will be able to compile-test every file that it
touches so I shall drop the patch.

Please fix it all up, compile-test *every* file, then resend.

If possible, against linux-next, please.  Quite a few things in this
area have been changed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/