linux-kernel - Re: [PATCH 6/6] Staging: rtl8187se: r8180

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120316052612.GF3163@mwanda>
Date:	Fri, 16 Mar 2012 08:26:12 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Andrew Miller <amiller@...lx.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] Staging: rtl8187se: r8180_dm.c: Removed old comments

On Thu, Mar 15, 2012 at 06:28:39PM -0400, Andrew Miller wrote:
> Removed some old comments
> 
> Signed-off-by: Andrew Miller <amiller@...lx.com>
> ---
>  drivers/staging/rtl8187se/r8180_dm.c |  307 +++-------------------------------
>  1 files changed, 21 insertions(+), 286 deletions(-)
> 
> diff --git a/drivers/staging/rtl8187se/r8180_dm.c b/drivers/staging/rtl8187se/r8180_dm.c
> index 54b676f..4d7a595 100644
> --- a/drivers/staging/rtl8187se/r8180_dm.c
> +++ b/drivers/staging/rtl8187se/r8180_dm.c
> @@ -1,15 +1,8 @@
> -/*#include "r8180.h" */
>  #include "r8180_dm.h"
>  #include "r8180_hw.h"
>  #include "r8180_93cx6.h"
> -/*{by amy 080312 */
>  
> -/*
> - *	Description:
> - *		Return TRUE if we shall perform High Power Mecahnism, FALSE otherwise.
> - *
> - *+by amy 080312
> - */
> + /*	Return TRUE if we shall perform High Power Mecahnism, FALSE otherwise. */
>  #define RATE_ADAPTIVE_TIMER_PERIOD      300
>  
>  bool CheckHighPower(struct net_device *dev)

I meant just remove the "*+by amy 080312" line, but I don't really
mind how you redid the formatting either.  Btw, the comment should
probably be a line below to go with the CheckHighPower() function
or people will think it belongs to the RATE_ADAPTIVE_TIMER_PERIOD
macro.

regards,
dan carpenter


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)