| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CANejiEU5t+Gq-4c=imR9CUNbs32jdLjBZrBw4PWy_UCRGp0==g@mail.gmail.com> Date: Sun, 18 Mar 2012 10:03:31 +0800 From: Shaohua Li <shli@...nel.org> To: Mark Lord <kernel@...savvy.com> Cc: NeilBrown <neilb@...e.de>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-raid@...r.kernel.org" <linux-raid@...r.kernel.org>, "axboe@...nel.dk" <axboe@...nel.dk> Subject: Re: [patch 0/7] Add TRIM support for raid linear/0/1/10 2012/3/18 Mark Lord <kernel@...savvy.com>: > On 12-03-13 10:47 PM, Shaohua Li wrote: >> On 3/14/12 10:24 AM, NeilBrown wrote: >>> On Mon, 12 Mar 2012 11:04:12 +0800 Shaohua Li <shli@...ionio.com> wrote: > .. >>> Also I wonder about handling failure in RAID1. >>> I think the code will currently treat it like a write error, and >>> maybe record a bad block (then fail the device is writing the badblock >>> record fails). Is that what were want? >> Mainly to simplify the code. And I thought a normal discard should not fail. >> If it fails, something is wrong, marked it as badblock maybe not bad. > > That sounds like a VERY bad idea. > Failures happen for lots of reasons, > but generic comm errors are not an excuse to suddenly mark sectors as bad. Not sure if I got it, but we treat discard similar like write. Did you mean discard request error is common? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists