linux-kernel - Re: [PATCH 1/2] s5p-tv: Add initial DT-support for TV mixer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120318182425.517BF3E07BF@localhost>
Date:	Sun, 18 Mar 2012 18:24:25 +0000
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Karol Lewandowski <k.lewandowsk@...sung.com>,
	t.stanislaws@...sung.com
Cc:	devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	thomas.abraham@...aro.org, m.szyprowski@...sung.com,
	kyungmin.park@...sung.com,
	Karol Lewandowski <k.lewandowsk@...sung.com>
Subject: Re: [PATCH 1/2] s5p-tv: Add initial DT-support for TV mixer

On Fri, 16 Mar 2012 16:42:11 +0100, Karol Lewandowski <k.lewandowsk@...sung.com> wrote:
> Signed-off-by: Karol Lewandowski <k.lewandowsk@...sung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
> ---
>  drivers/media/video/s5p-tv/mixer_drv.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/video/s5p-tv/mixer_drv.c b/drivers/media/video/s5p-tv/mixer_drv.c
> index 0064309..2eb48ea 100644
> --- a/drivers/media/video/s5p-tv/mixer_drv.c
> +++ b/drivers/media/video/s5p-tv/mixer_drv.c
> @@ -448,6 +448,14 @@ static int __devexit mxr_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +#ifdef CONFIG_OF
> +static const struct of_device_id mxr_dt_match[] = {
> +	{ .compatible = "samsung,s5pv210-tvmixer" },

Need to add this new compatible string to
Documentation/devicetree/bindings.

Otherwise looks good.

g.

> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, mxr_dt_match);
> +#endif
> +
>  static struct platform_driver mxr_driver __refdata = {
>  	.probe = mxr_probe,
>  	.remove = __devexit_p(mxr_remove),
> @@ -455,6 +463,7 @@ static struct platform_driver mxr_driver __refdata = {
>  		.name = MXR_DRIVER_NAME,
>  		.owner = THIS_MODULE,
>  		.pm = &mxr_pm_ops,
> +		.of_match_table = of_match_ptr(mxr_dt_match),
>  	}
>  };
>  
> -- 
> 1.7.9
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/