linux-kernel - Re: [PATCH] ARM: iop: add missing includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120319194016.GA708@ultra.musicnaut.iki.fi>
Date:	Mon, 19 Mar 2012 21:40:16 +0200
From:	Aaro Koskinen <aaro.koskinen@....fi>
To:	Olof Johansson <olof@...om.net>
Cc:	Dan Williams <dan.j.williams@...el.com>,
	Lennert Buytenhek <kernel@...tstofly.org>,
	linux-arm-kernel@...ts.infradead.org, linux@....linux.org.uk,
	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org
Subject: Re: [PATCH] ARM: iop: add missing includes

Hi,

On Wed, Feb 15, 2012 at 02:24:42PM -0800, Olof Johansson wrote:
> Resolves two build breaks. One is a boatload of "unknown type name 'u32'"
> in iop3xx.h due to missing include of <linux/types.h>.
> 
> The other is:
> arch/arm/plat-iop/restart.c: In function 'iop3xx_restart':
> arch/arm/plat-iop/restart.c:18:2: error: implicit declaration of function 'soft_restart' [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Olof Johansson <olof@...om.net>

Any chance to get this patch into 3.3.1 (stable), when and if such is made?

The v3.3 fails to build for IOP boards without this.

> ---
> 
>  arch/arm/include/asm/hardware/iop3xx.h |    2 ++
>  arch/arm/plat-iop/restart.c            |    1 +
>  2 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/include/asm/hardware/iop3xx.h b/arch/arm/include/asm/hardware/iop3xx.h
> index 077c323..ec0224d 100644
> --- a/arch/arm/include/asm/hardware/iop3xx.h
> +++ b/arch/arm/include/asm/hardware/iop3xx.h
> @@ -15,6 +15,8 @@
>  #ifndef __IOP3XX_H
>  #define __IOP3XX_H
>  
> +#include <linux/types.h>
> +
>  /*
>   * IOP3XX GPIO handling
>   */
> diff --git a/arch/arm/plat-iop/restart.c b/arch/arm/plat-iop/restart.c
> index 6a85a0c..a6ee3b6 100644
> --- a/arch/arm/plat-iop/restart.c
> +++ b/arch/arm/plat-iop/restart.c
> @@ -8,6 +8,7 @@
>   * published by the Free Software Foundation.
>   */
>  #include <asm/hardware/iop3xx.h>
> +#include <asm/system.h>
>  #include <mach/hardware.h>
>  
>  void iop3xx_restart(char mode, const char *cmd)
> -- 
> 1.7.9.209.gb6b3b

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/